From: Ewan Mellor <ewan@xensource.com>
Subject: Re: [PATCH] make uninstall
Date: Sat, 12 Nov 2005 17:43:59 +0000
Message-ID: <20051112174359.GF24103@leeni.uk.xensource.com>
References: <4374B629.D169.003C.0@novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4374B629.D169.003C.0@novell.com>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Charles Coffing <ccoffing@novell.com>
Cc: xen-devel@lists.xensource.com

On Fri, Nov 11, 2005 at 03:19:48PM -0700, Charles Coffing wrote:

> "make uninstall" was not cleaning up some udev rules.  Also, on x86_64
> there was stuff left in /usr/lib/xen, not just /usr/$LIBDIR/xen.
> 
> 
> ---  xen- unstable.hg/Makefile.orig       2005- 11- 11
> 09:20:39.000000000 - 0700
> +++ xen- unstable.hg/Makefile    2005- 11- 11 09:31:50.000000000 -
> 0700
> @@ - 167,6 +167,9 @@
>         [ - d $(D)/etc/xen ] && mv - f $(D)/etc/xen $(D)/etc/xen.old-
> `date +%s` || true
>         rm - rf $(D)/etc/init.d/xend*
>         rm - rf $(D)/etc/hotplug/xen- backend.agent
> +       rm - f  $(D)/etc/udev/rules.d/xen- backend.rules
> +       rm - f  $(D)/etc/udev/xen- backend.rules
> +       rm - f  $(D)/etc/sysconfig/xendomains
>         rm - rf $(D)/var/run/xen* $(D)/var/lib/xen*
>         rm - rf $(D)/boot/*xen*
>         rm - rf $(D)/lib/modules/*xen*
> @@ - 179,7 +182,8 @@
>         rm - rf $(D)/usr/$(LIBDIR)/libxenctrl*
> $(D)/usr/$(LIBDIR)/libxenguest*
>         rm - rf $(D)/usr/$(LIBDIR)/libxenstore*
>         rm - rf $(D)/usr/$(LIBDIR)/python/xen $(D)/usr/$(LIBDIR)/xen
> -        rm - rf $(D)/usr/$(LIBDIR)/xen/bin
> +       rm - rf $(D)/usr/$(LIBDIR)/xen/
> +       rm - rf $(D)/usr/lib/xen/
>         rm - rf $(D)/usr/sbin/xen* $(D)/usr/sbin/netfix
> $(D)/usr/sbin/xm
>         rm - rf $(D)/usr/share/doc/xen
>         rm - rf $(D)/usr/share/xen

Charles, I've applied this.  However, as you can see, your mailer has made a
right mess of the patch, putting a space after each minus.  Could you make
sure that it doesn't do this again, please?

Thanks for your patch in any case,

Ewan.