From: Tony Breeds Subject: [PATCH] avoid NULL pointer dereference. Date: Thu, 24 Nov 2005 15:48:30 +1100 Message-ID: <20051124044830.GJ25348@bakeyournoodle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org Hi All, xen/common/acm_ops.c, check for a NULL pointer and then cheerfully dereferences it. Signed-off-by: Tony Breeds diff -r 4b6e8661fe2b xen/common/acm_ops.c --- a/xen/common/acm_ops.c Thu Nov 24 01:32:39 2005 +++ b/xen/common/acm_ops.c Thu Nov 24 15:45:57 2005 @@ -172,7 +172,7 @@ } if (subj->ssid == NULL) { put_domain(subj); - ret = -ESRCH; + return -ESRCH; } ssidref1 = ((struct acm_ssid_domain *)(subj->ssid))->ssidref; put_domain(subj); Yours Tony linux.conf.au http://linux.conf.au/ || http://lca2006.linux.org.au/ Jan 23-28 2006 The Australian Linux Technical Conference!