From: Tony Breeds <tony@bakeyournoodle.com>
Subject: [PATCH] Drop useless if() ?
Date: Mon, 28 Nov 2005 15:18:25 +1100
Message-ID: <20051128041825.GN25348@bakeyournoodle.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <xen-devel-bounces@lists.xensource.com>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Xen Mailing List <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

Hello All,
	I noticed the following in xen/common/domain.c in boot_vcpu()

...
	if ( (rc = arch_set_info_guest(v, ctxt)) != 0 )
		return rc;

	return rc;
...

Is there any reason to not drop the if?  as in the patch below.

Signed-off-by: Tony Breeds <tony@bakeyournoodle.com>
--------
diff -r 6a666940fa04 xen/common/domain.c
--- a/xen/common/domain.c	Sun Nov 20 09:19:38 2005
+++ b/xen/common/domain.c	Mon Nov 28 15:02:12 2005
@@ -380,9 +380,7 @@
 
     BUG_ON(test_bit(_VCPUF_initialised, &v->vcpu_flags));
 
-    if ( (rc = arch_set_info_guest(v, ctxt)) != 0 )
-        return rc;
-
+    rc = arch_set_info_guest(v, ctxt);
     return rc;
 }
 

Yours Tony

   linux.conf.au       http://linux.conf.au/ || http://lca2006.linux.org.au/
   Jan 23-28 2006      The Australian Linux Technical Conference!