From: Andrew Morton Subject: Re: [patch 146/233] fix possible PAGE_CACHE_SHIFT overflows Date: Sun, 8 Jan 2006 13:35:36 -0800 Message-ID: <20060108133536.7acf0003.akpm@osdl.org> References: <200601080903.k0893GE9015082@shell0.pdx.osdl.net> <1136749077.10599.2.camel@kleikamp.austin.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: torvalds@osdl.org, aia21@cantab.net, blaisorblade@yahoo.it, dhowells@redhat.com, dwmw2@infradead.org, green@linuxhacker.ru, hch@lst.de, jdike@addtoit.com, linux-fsdevel@vger.kernel.org, miklos@szeredi.hu, neilb@cse.unsw.edu.au, reiserfs-dev@namesys.com, rmk@arm.linux.org.uk, trond.myklebust@fys.uio.no, zippel@linux-m68k.org Return-path: Received: from smtp.osdl.org ([65.172.181.4]:44464 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S1161214AbWAHVgp (ORCPT ); Sun, 8 Jan 2006 16:36:45 -0500 To: Dave Kleikamp In-Reply-To: <1136749077.10599.2.camel@kleikamp.austin.ibm.com> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Dave Kleikamp wrote: > > On Sun, 2006-01-08 at 01:03 -0800, akpm@osdl.org wrote: > > From: Andrew Morton > > > > We've had two instances recently of overflows when doing > > > > 64_bit_value = (32_bit_value << PAGE_CACHE_SHIFT) > > > > I did a tree-wide grep of `<<.*PAGE_CACHE_SHIFT' and this is the result. > > > > - afs_rxfs_fetch_descriptor.offset is of type off_t, which seems broken. > > > > - jfs and jffs are limited to 4GB anyway. > > What makes you say jfs is limited to 4GB? No matter. There shouldn't > be any problem in jfs anyway. > I think I meant jffs and jffs2. Off-by-one ;)