From: Matt Domsch Date: Sun, 08 Jan 2006 22:32:00 +0000 Subject: Re: MODULE_VERSION useless? (was Re: [KJ] adding missing MODULE_* Message-Id: <20060108223200.GA14784@lists.us.dell.com> MIME-Version: 1 Content-Type: multipart/mixed; boundary="===============75866795676960586==" List-Id: References: <20051230000400.GS18040@outflux.net> <20060108204549.GB5864@mipter.zuzino.mipt.ru> <200601081855.17723.carlos@embedded.cl> <20060108215800.GA31398@kroah.com> In-Reply-To: <20060108215800.GA31398@kroah.com> To: Greg KH Cc: Carlos Manuel Duclos Vergara , kernel-janitors@lists.osdl.org, Kees Cook , linux-kernel@vger.kernel.org --===============75866795676960586== Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sun, Jan 08, 2006 at 01:58:00PM -0800, Greg KH wrote: > On Sun, Jan 08, 2006 at 06:55:16PM -0300, Carlos Manuel Duclos Vergara wrote: > > Hi everyone, > > > > I have two ideas about what to do with MODULE_VERSION: > > 1.- Defining MODULE_VERSION = KERNEL_VERSION > > No. > > > 2.- Schedule it for removal in one or two more versions, and automagically use > > the KERNEL_VERSION as module's version. > > No, just let the authors of the different drivers that want to use > MODULE_VERSION use it (for some people it does matter, and they keep it > up to date.) Everyone else, just don't add it if you don't care about > it. DKMS (http://linux.dell.com/dkms/) uses it to tell if one version is newer than another. For the couple dozen modules Dell regularly cares about, the module authors have been doing a good job of keeping MODULE_VERSION correct, for exactly this reason. > In short, leave it alone :) Please! -- Matt Domsch Software Architect Dell Linux Solutions linux.dell.com & www.dell.com/linux Linux on Dell mailing lists @ http://lists.us.dell.com --===============75866795676960586== Content-Type: text/plain; charset="iso-8859-1" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline _______________________________________________ Kernel-janitors mailing list Kernel-janitors@lists.osdl.org https://lists.osdl.org/mailman/listinfo/kernel-janitors --===============75866795676960586==--