From: Vincent Hanquez Subject: Re: [PATCH 2.6.12.6-xen] sysfs attributes for xen Date: Sat, 28 Jan 2006 13:23:35 +0100 Message-ID: <20060128122335.GA24382@snarc.org> References: <43DAD4DB.4090708@us.ibm.com> <20060128023828.GA20881@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20060128023828.GA20881@kroah.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Greg KH Cc: "Mike D. Day" , xen-devel@lists.xensource.com, lkml List-Id: xen-devel@lists.xenproject.org On Fri, Jan 27, 2006 at 06:38:28PM -0800, Greg KH wrote: > > + > > +int __init > > +hyper_sysfs_init(void) > > +{ > > + int err ; > > + > > + if( 0 == (err = subsystem_register(&hypervisor_subsys)) ) { > > + xen_kset.subsys = &hypervisor_subsys; > > + err = kset_register(&xen_kset); > > + } > > Is this the xen coding style? If so, it's got to change before making > it into mainline... Please fix this up. No, this is not coding style we use for linux related files. The patch really need to be fix ... -- Vincent Hanquez