From: Greg KH Subject: Re: [Xen-devel] Re: [PATCH 2.6.12.6-xen] sysfs attributes for xen Date: Mon, 30 Jan 2006 09:26:09 -0800 Message-ID: <20060130172609.GA15949@kroah.com> References: <43DAD4DB.4090708@us.ibm.com> <1138637931.19801.101.camel@localhost.localdomain> <43DE45A4.6010808@us.ibm.com> <1138640666.19801.106.camel@localhost.localdomain> <43DE4A1D.4050501@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <43DE4A1D.4050501@us.ibm.com> Sender: linux-kernel-owner@vger.kernel.org To: "Mike D. Day" Cc: Dave Hansen , xen-devel@lists.xensource.com, lkml List-Id: xen-devel@lists.xenproject.org On Mon, Jan 30, 2006 at 12:17:17PM -0500, Mike D. Day wrote: > Dave Hansen wrote: > >In the final version, there will be available Xen headers, and the patch > >won't need the open-coded 1024? > > Good question, I need some advice. The Xen hcall headers get soft-linked > into every paravirtualized OS tree: linux, bsd, solaris, etc. In linux > right now the xen version.h shows up as /include/asm-xen/version.h. > > This file uses typedefs for every important parameter. For example, typedef > char [1024] xen_capabilities_info_t;. > But as Greg says TYPEDEFS ARE EVIL. Then just make it a structure. All the operating systems will be able to handle that just fine :) thanks, greg k-h