From: Bjorn Helgaas Subject: [PATCH] ACPI: fix vendor resource length computation Date: Tue, 14 Feb 2006 16:13:09 -0700 Message-ID: <200602141613.09152.bjorn.helgaas@hp.com> References: <971FCB6690CD0E4898387DBF7552B90E0452B0D7@orsmsx403.amr.corp.intel.com> <200602131722.28703.bjorn.helgaas@hp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <200602131722.28703.bjorn.helgaas@hp.com> Content-Disposition: inline Sender: linux-ia64-owner@vger.kernel.org To: Andreas Schwab Cc: Thomas Renninger , "Moore, Robert" , "Luck, Tony" , "Brown, Len" , linux-acpi@vger.kernel.org, linux-ia64@vger.kernel.org, Andrew Morton , efocht@hpce.nec.com List-Id: linux-acpi@vger.kernel.org acpi_rs_get_list_length() needs to account for all the vendor-defined data bytes. Failing to include these causes buffers to be sized too small, which causes slab corruption when we later convert AML to resources and run off the end of the buffer. I'm no expert on this code, so please scrutinize this carefully. This causes slab corruption on machines that use ACPI vendor-defined resources. All HP ia64 machines do, and I'm told that some NEC machines may as well. So if the fix is correct, it would be good to have it in 2.6.16. Signed-off-by: Bjorn Helgaas Index: work-mm4/drivers/acpi/resources/rscalc.c =================================================================== --- work-mm4.orig/drivers/acpi/resources/rscalc.c 2006-02-14 13:32:50.000000000 -0700 +++ work-mm4/drivers/acpi/resources/rscalc.c 2006-02-14 13:33:25.000000000 -0700 @@ -391,8 +391,7 @@ * Ensure a 32-bit boundary for the structure */ extra_struct_bytes = - ACPI_ROUND_UP_to_32_bITS(resource_length) - - resource_length; + ACPI_ROUND_UP_to_32_bITS(resource_length); break; case ACPI_RESOURCE_NAME_END_TAG: @@ -408,8 +407,7 @@ * Add vendor data and ensure a 32-bit boundary for the structure */ extra_struct_bytes = - ACPI_ROUND_UP_to_32_bITS(resource_length) - - resource_length; + ACPI_ROUND_UP_to_32_bITS(resource_length); break; case ACPI_RESOURCE_NAME_ADDRESS32: