From: Heiko Carstens Subject: Re: [ PATCH 2.6.16-rc3-xen 3/3] sysfs: export Xen hypervisor attributes to sysfs Date: Wed, 22 Feb 2006 13:26:13 +0100 Message-ID: <20060222122613.GA9295@osiris.boeblingen.de.ibm.com> References: <43FB2642.7020109@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <43FB2642.7020109@us.ibm.com> Sender: linux-kernel-owner@vger.kernel.org To: "Mike D. Day" Cc: xen-devel@lists.xensource.com, lkml , Greg KH , Dave Hansen List-Id: xen-devel@lists.xenproject.org > +static ssize_t by_show(struct kobject * kobj, > + struct attribute * attr, > + char * page) > +{ > + int err = 0; > + struct xen_compile_info * info = > + kmalloc(sizeof(struct xen_compile_info), GFP_KERNEL); > + if (info ) { > + if (0 == HYPERVISOR_xen_version(XENVER_compile_info, info)) > + return sprintf(page, "%s\n", info->compile_by); > + kfree(info); > + } > + return err; > +} Looks like you have a memory leak here. There's at least one more of the same kind in your code. Heiko