From: Andi Kleen Subject: Re: [patch 1/4] net: percpufy frequently used vars -- add percpu_counter_mod_bh Date: Thu, 9 Mar 2006 05:14:55 +0100 Message-ID: <200603090514.56740.ak@suse.de> References: <20060307181301.4dd6aa96.akpm@osdl.org> <20060308163258.36f3bd79.akpm@osdl.org> <20060309080651.GA3599@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Cc: Andrew Morton , bcrl@kvack.org, linux-kernel@vger.kernel.org, davem@davemloft.net, netdev@vger.kernel.org, shai@scalex86.org Return-path: To: Ravikiran G Thirumalai In-Reply-To: <20060309080651.GA3599@localhost.localdomain> Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Thursday 09 March 2006 09:06, Ravikiran G Thirumalai wrote: > On Wed, Mar 08, 2006 at 04:32:58PM -0800, Andrew Morton wrote: > > Ravikiran G Thirumalai wrote: > > > > > > On Wed, Mar 08, 2006 at 03:43:21PM -0800, Andrew Morton wrote: > > > > Benjamin LaHaise wrote: > > > > > > > > > > I think it may make more sense to simply convert local_t into a long, given > > > > > that most of the users will be things like stats counters. > > > > > > > > > > > > > Yes, I agree that making local_t signed would be better. It's consistent > > > > with atomic_t, atomic64_t and atomic_long_t and it's a bit more flexible. > > > > > > > > Perhaps. A lot of applications would just be upcounters for statistics, > > > > where unsigned is desired. But I think the consistency argument wins out. > > > > > > It already is... for most of the arches except x86_64. > > > > x86 uses unsigned long. > > Here's a patch making x86_64 local_t to 64 bits like other 64 bit arches. > This keeps local_t unsigned long. (We can change it to signed value > along with other arches later in one go I guess) I already did that change in my tree (except it's currently unsigned long as Andrew Indicated) -Andi >