From: Ewan Mellor Subject: Re: [PATCH] clean up parsing of /proc/xen/balloon in xend Date: Fri, 10 Mar 2006 13:18:20 +0000 Message-ID: <20060310131820.GD17940@leeni.uk.xensource.com> References: <441063AC.D169.003C.0@novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <441063AC.D169.003C.0@novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Charles Coffing Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On Thu, Mar 09, 2006 at 07:19:59PM -0500, Charles Coffing wrote: > The attached patch cleans up the parsing of /proc/xen/balloon that > occurs in xend. Currently, the parsing is hard-coded; it expects that > the desired number is on the first line. My patch is more robust; it > lets values be retrieved by a label. It also exposes a few functions to > retrieve the current allocation and the target allocation. > > By abstracting this a little better, I'll be able to address a few > other issues in subsequent patches. Mostly, this allows for better > error checking and guidance for the user. For example, by exposing > get_dom0_current_alloc(), we can (elsewhere, in a later patch) calculate > how large of a VM could potentially be started. This is useful, as it > lets simple VM-creation GUIs guide the user towards reasonable memory > values for new VMs. > > Signed-off-by: Charles Coffing Applied, thank you. Ewan.