From: Hollis Blanchard Subject: [patch] print panic message before trapping to debugger Date: Tue, 14 Mar 2006 15:12:21 -0600 Message-ID: <200603141512.21546.hollisb@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org I've found it useful to display the panic message *before* dropping into the debugger. Once there it may be very difficult to find the original message, and often a debugger isn't even needed if you can see what panicked. Signed-off-by: Hollis Blanchard # HG changeset patch # User hollisb@basalt # Node ID c6267fda4f4c899dbf0f23191a658d7f18ca7c3c # Parent 686cd624618cead274ea9850f0997d41c6134283 print panic message before trapping to debugger diff -r 686cd624618c -r c6267fda4f4c xen/drivers/char/console.c --- a/xen/drivers/char/console.c Tue Mar 14 14:56:55 2006 -0600 +++ b/xen/drivers/char/console.c Tue Mar 14 15:02:27 2006 -0600 @@ -683,8 +683,6 @@ void panic(const char *fmt, ...) (void)vsnprintf(buf, sizeof(buf), fmt, args); va_end(args); - debugger_trap_immediate(); - /* Spit out multiline message in one go. */ spin_lock_irqsave(&lock, flags); printk("\n****************************************\n"); @@ -694,6 +692,8 @@ void panic(const char *fmt, ...) printk("Reboot in five seconds...\n"); spin_unlock_irqrestore(&lock, flags); + debugger_trap_immediate(); + watchdog_disable(); mdelay(5000); machine_restart(0); -- Hollis Blanchard IBM Linux Technology Center