From: Christoph Hellwig Subject: Re: [RFC, PATCH 3/24] i386 Vmi interface definition Date: Tue, 14 Mar 2006 15:25:59 +0000 Message-ID: <20060314152559.GC16921@infradead.org> References: <200603131801.k2DI1EAe005650@zach-dev.vmware.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <200603131801.k2DI1EAe005650@zach-dev.vmware.com> Sender: linux-kernel-owner@vger.kernel.org To: Zachary Amsden Cc: Linus Torvalds , Linux Kernel Mailing List , Virtualization Mailing List , Xen-devel , Andrew Morton , Dan Hecht , Dan Arai , Anne Holler , Pratap Subrahmanyam , Christopher Li , Joshua LeVasseur , Chris Wright , Rik Van Riel , Jyothy Reddy , Jack Lo , Kip Macy , Jan Beulich , Ky Srinivasan , Wim Coekaerts , Leendert van Doorn List-Id: xen-devel@lists.xenproject.org On Mon, Mar 13, 2006 at 10:01:14AM -0800, Zachary Amsden wrote: > Master definition of VMI interface, including calls, constants, and > interface version. This is a totally horrible style. There's absolutely no need to find your own sized integer types, please use the standard kernel ones. Also don't use camel case and #pack but rather __attribute__. Also please avoid // comments. Also please remove all the historical version garbage, we don't care about that.