From: Hollis Blanchard Subject: Re: [RFC] build configuration Date: Wed, 15 Mar 2006 12:01:41 -0600 Message-ID: <200603151201.42506.hollisb@us.ibm.com> References: <200603151128.09354.hollisb@us.ibm.com> <721cde0877720323d2559cc0440df291@cl.cam.ac.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <721cde0877720323d2559cc0440df291@cl.cam.ac.uk> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On Wednesday 15 March 2006 11:44, Keir Fraser wrote: > > So far we've kept the number of 'user serviceable' build options very > small, preferring to select optional things at run time, and specify > non-optional things by hardcoding in asm/config.h. > > What is it that PPC requires in addition to this? If it's the ability > to more easlly have those config.h hardcodings affect what files get > built, then maybe we can pull out those hardcoded CONFIG_ items into a > per-arch text file that gets processed into a header file and into a > Makefile include. Yup, that's exactly what it is. While I was looking into that, I noticed that the build options are a little disorganized, and it could be nice to have them all collected in one place. Further, it would clean up some of the existing makefiles. For example: ifeq ($(XEN_TARGET_ARCH),x86_64) LIBDIR = lib64 else LIBDIR = lib endif Instead of that, just "include Config-$(XEN_TARGET_ARCH).mk" and let it set LIBDIR. Now think about ACPI: most archs want it right now, but PPC doesn't. Rather than have lots of ifeq elif elif ... in xen/drivers/Makefile, it would be far simpler to do: OBJS-$(CONFIG_ACPI) += acpi and let Config-$(XEN_TARGET_ARCH).mk set CONFIG_ACPI or not. -- Hollis Blanchard IBM Linux Technology Center