From: Aron Griffis Subject: [PATCH] minor Makefile fix Date: Tue, 21 Mar 2006 16:51:56 -0500 Message-ID: <20060321215156.GE27078@olive.flatmonk> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0242043072==" Return-path: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Mime-version: 1.0 Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org --===============0242043072== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Qz2CZ664xQdCRdPu" Content-Disposition: inline --Qz2CZ664xQdCRdPu Content-Type: text/plain; charset=utf8 Content-Disposition: inline The patch below prevents a stray error message in the case that either DISTDIR or DESTDIR is empty, by preventing readlink from being called in that case. Another option would be to use readlink -s, but that has the undesirable effect of staying silent in situations other than empty DISTDIR/DESTDIR Signed-off-by: Aron Griffis diff -r 9afd25b90af4 tools/examples/Makefile --- a/tools/examples/Makefile Mon Mar 20 09:56:58 2006 -0700 +++ b/tools/examples/Makefile Tue Mar 21 16:53:04 2006 -0500 @@ -38,8 +38,8 @@ UDEV_RULES_DIR = /etc/udev UDEV_RULES_DIR = /etc/udev UDEV_RULES = xen-backend.rules -DI = $(shell readlink -f $(DISTDIR)) -DE = $(shell readlink -f $(DESTDIR)) +DI = $(if $(DISTDIR),$(shell readlink -f $(DISTDIR)),) +DE = $(if $(DESTDIR),$(shell readlink -f $(DESTDIR)),) ifeq ($(findstring $(DI),$(DE)),$(DI)) HOTPLUGS=install-hotplug install-udev else --Qz2CZ664xQdCRdPu Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2.1 (GNU/Linux) iD8DBQFEIHV8woQDZl5qPGsRAv2XAJ9qlSUxNNcoCT851DH7aIwIe3aBzACfWG+t 8CFHODCaQqCRBFripxys0Wo= =GfcP -----END PGP SIGNATURE----- --Qz2CZ664xQdCRdPu-- --===============0242043072== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --===============0242043072==--