From: Andi Kleen Subject: Re: [RFC PATCH 16/35] subarch support for interrupt and exception gates Date: Wed, 22 Mar 2006 14:45:46 +0100 Message-ID: <200603221445.46490.ak@suse.de> References: <20060322063040.960068000@sorel.sous-sol.org> <20060322063752.437169000@sorel.sous-sol.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20060322063752.437169000@sorel.sous-sol.org> Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org To: virtualization@lists.osdl.org Cc: Chris Wright , linux-kernel@vger.kernel.org, xen-devel@lists.xensource.com, Ian Pratt List-Id: xen-devel@lists.xenproject.org On Wednesday 22 March 2006 07:30, Chris Wright wrote: > Abstract the code that sets up interrupt and exception gates, and > add a separate subarch implementation for Xen. AFAIK the only difference is that Xen uses a table of them to pass the hypervisor and normal Linux calls the macros directly, right? I would suggest you just use the table for normal Linux too and make the function that processes them natively !CONFIG_XEN I guess it will make the code smaller for the normal case and people happy. That would be much cleaner than just separating it out. -Andi