From: Andi Kleen Subject: Re: [RFC PATCH 29/35] Add the Xen virtual console driver. Date: Wed, 22 Mar 2006 15:17:41 +0100 Message-ID: <200603221517.42144.ak@suse.de> References: <20060322063040.960068000@sorel.sous-sol.org> <20060322063804.956561000@sorel.sous-sol.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20060322063804.956561000@sorel.sous-sol.org> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: virtualization@lists.osdl.org Cc: Chris Wright , Ian Pratt , xen-devel@lists.xensource.com, linux-kernel@vger.kernel.org List-Id: xen-devel@lists.xenproject.org On Wednesday 22 March 2006 07:31, Chris Wright wrote: Basically it's the same thing as the buffer in printk.c except that it does input too. You could safe a lot of code by just teaching the Hypervisor about that one. Not sure it is fully practical though, > --- xen-subarch-2.6.orig/drivers/char/tty_io.c > +++ xen-subarch-2.6/drivers/char/tty_io.c > @@ -132,6 +132,8 @@ LIST_HEAD(tty_drivers); /* linked list > vt.c for deeply disgusting hack reasons */ > DECLARE_MUTEX(tty_sem); > > +int console_use_vt = 1; This doesn't have anything to do with early console. Why is it needed? Looks like a ugly hack. > +#define __RETCODE 0 What is that? > +/*** Useful function for console debugging -- goes straight to Xen. ***/ > +asmlinkage int xprintk(const char *fmt, ...) In normal Linux this is called early_printk() > +{ > + va_list args; > + int printk_len; > + static char printk_buf[1024]; Who does the locking here? -Andi