From: Andi Kleen Subject: Re: [RFC PATCH 26/35] Add Xen subarch reboot support Date: Wed, 22 Mar 2006 15:21:57 +0100 Message-ID: <200603221521.57639.ak@suse.de> References: <20060322063040.960068000@sorel.sous-sol.org> <20060322063801.949835000@sorel.sous-sol.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20060322063801.949835000@sorel.sous-sol.org> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: virtualization@lists.osdl.org Cc: Chris Wright , Ian Pratt , xen-devel@lists.xensource.com, linux-kernel@vger.kernel.org List-Id: xen-devel@lists.xenproject.org On Wednesday 22 March 2006 07:31, Chris Wright wrote: > + static char *envp[] = { "HOME=/", "TERM=linux", > + "PATH=/sbin:/usr/sbin:/bin:/usr/bin", NULL }; > + static char *restart_argv[] = { "/sbin/reboot", NULL }; > + static char *poweroff_argv[] = { "/sbin/poweroff", NULL }; It would be better if that was user configurable. > + extern asmlinkage long sys_reboot(int magic1, int magic2, > + unsigned int cmd, void *arg); This is what linux/syscalls.h is there for. > + daemonize("shutdown"); What is that good for? > + > + switch (shutting_down) { > + case SHUTDOWN_POWEROFF: > + case SHUTDOWN_HALT: > + if (execve("/sbin/poweroff", poweroff_argv, envp) < 0) { You should probably keep track if the execve already happened and if it is called again do the sys_reboot directly. -Andi