From: Christoph Hellwig Subject: Re: [RFC PATCH 35/35] Add Xen virtual block device driver. Date: Wed, 22 Mar 2006 16:54:44 +0000 Message-ID: <20060322165444.GA16291@infradead.org> References: <20060322063040.960068000@sorel.sous-sol.org> <20060322063809.005748000@sorel.sous-sol.org> <44217DBD.8030201@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <44217DBD.8030201@us.ibm.com> Sender: linux-kernel-owner@vger.kernel.org To: Anthony Liguori Cc: Chris Wright , linux-kernel@vger.kernel.org, virtualization@lists.osdl.org, xen-devel@lists.xensource.com, Ian Pratt List-Id: xen-devel@lists.xenproject.org On Wed, Mar 22, 2006 at 10:39:25AM -0600, Anthony Liguori wrote: > This is another thing that has always put me off. The virtual block > device driver has the ability to masquerade as other types of block > devices. It actually claims to be an IDE or SCSI device allocating the > appropriate major/minor numbers. > > This seems to be pretty evil and creating interesting failure conditions > for users who load IDE or SCSI modules. I've seen it trip up a number > of people in the past. I think we should only ever use the major number > that was actually allocated to us. Exactly. We vetoed crap like that in the ibm vio drivers already so it was removed before merging those drivers.