From: Andi Kleen Subject: Re: [RFC, PATCH 5/24] i386 Vmi code patching Date: Wed, 22 Mar 2006 21:15:44 +0100 Message-ID: <200603222115.46926.ak@suse.de> References: <200603131802.k2DI2nv8005665@zach-dev.vmware.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <200603131802.k2DI2nv8005665@zach-dev.vmware.com> Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org To: virtualization@lists.osdl.org Cc: Zachary Amsden , Linus Torvalds , Linux Kernel Mailing List , Xen-devel , Andrew Morton , Dan Hecht , Dan Arai , Anne Holler , Pratap Subrahmanyam , Christopher Li , Joshua LeVasseur , Chris Wright , Rik Van Riel , Jyothy Reddy , Jack Lo , Kip Macy , Jan Beulich , Ky Srinivasan , Wim Coekaerts , Leendert van Doorn List-Id: xen-devel@lists.xenproject.org On Monday 13 March 2006 19:02, Zachary Amsden wrote: > The VMI ROM detection and code patching mechanism is illustrated in > setup.c. There ROM is a binary block published by the hypervisor, and > and there are certainly implications of this. ROMs certainly have a > history of being proprietary, very differently licensed pieces of > software, and mostly under non-free licenses. Before jumping to the > conclusion that this is a bad thing, let us consider more carefully > why hiding the interface layer to the hypervisor is actually a good > thing. How about you fix all these issues you describe here first and then submit it again? The disassembly stuff indeed doesn't look like something that belongs in the kernel. -Andi