From: Andi Kleen Subject: Re: [RFC, PATCH 10/24] i386 Vmi descriptor changes Date: Wed, 22 Mar 2006 21:24:01 +0100 Message-ID: <200603222124.03284.ak@suse.de> References: <200603131806.k2DI6jlJ005700@zach-dev.vmware.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <200603131806.k2DI6jlJ005700@zach-dev.vmware.com> Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org To: virtualization@lists.osdl.org Cc: Zachary Amsden , Linus Torvalds , Linux Kernel Mailing List , Xen-devel , Andrew Morton , Dan Hecht , Dan Arai , Anne Holler , Pratap Subrahmanyam , Christopher Li , Joshua LeVasseur , Chris Wright , Rik Van Riel , Jyothy Reddy , Jack Lo , Kip Macy , Jan Beulich , Ky Srinivasan , Wim Coekaerts , Leendert van Doorn List-Id: xen-devel@lists.xenproject.org > -#define _set_gate(gate_addr,type,dpl,addr,seg) \ > -do { \ > - int __d0, __d1; \ > - __asm__ __volatile__ ("movw %%dx,%%ax\n\t" \ > - "movw %4,%%dx\n\t" \ > - "movl %%eax,%0\n\t" \ > - "movl %%edx,%1" \ > - :"=m" (*((long *) (gate_addr))), \ > - "=m" (*(1+(long *) (gate_addr))), "=&a" (__d0), "=&d" (__d1) \ > - :"i" ((short) (0x8000+(dpl<<13)+(type<<8))), \ > - "3" ((char *) (addr)),"2" ((seg) << 16)); \ > -} while (0) The ugly piece of code doesn't do anything priviledged. So why do you want to move it? -Andi