From: Ewan Mellor Subject: Re: [PATCH] Fixup a couple of problems with XML-RPC error handling Date: Fri, 24 Mar 2006 13:40:27 +0000 Message-ID: <20060324134027.GD8825@leeni.uk.xensource.com> References: <44230452.7000703@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <44230452.7000703@us.ibm.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Anthony Liguori Cc: xen-devel List-Id: xen-devel@lists.xenproject.org On Thu, Mar 23, 2006 at 02:25:54PM -0600, Anthony Liguori wrote: > This fixes a number of problems introduces in the recent XML-RPC > check-in. The higher level errors are a great idea and I've also > extended it a bit to have a slightly nicer interface. Please apply. > > Regards, > > Anthony Liguori > # HG changeset patch > # User anthony@rhesis.austin.ibm.com > # Node ID e4c39bd3fb27129532d55f7bb30c800143b390b3 > # Parent 8f722ac17efa4ba84eb6c678c7f33dab82fceb3e > 1) Introduce new exception type XendInvalidDomain that maps to the high level > XEND_INVALID_DOMAIN faultType. > 2) Fix exception logic in XMLRPCServer > 3) Fix TCP server > 4) Remove catching of ProtocolError in main.py. ProtocolErrors only occur > when there is an exception in the exception handling code which shouldn't > ever happen. I've reproduced the error cases described by Ewan with > xend_domain_setTargetMemory and once I fixed the exception logic, I get a > normal faultType of 1 as would be expected. > > Signed-off-by: Anthony Liguori Applied, thank you. Ewan.