From: John Levon Subject: [PATCH] fix xspy stack corruption Date: Thu, 13 Apr 2006 18:35:18 +0100 Message-ID: <20060413173518.GA12699@totally.trollied.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org This was fun to find... we were unlucky enough for the corruption to zero out the bottom 2 bytes of the saved %ebp. regards, john # HG changeset patch # User john.levon@sun.com # Node ID 09a9fd49601b9b5315843eb62ad7798ccb0ccd0d # Parent 2a7a46dd3bd6a600deee21990aef41456cba9724 Fix stack corruption in the libxs python interface. domid_t is a short; instead use uint32_t like we do in xc.c. Signed-off-by: John Levon diff -r 2a7a46dd3bd6 -r 09a9fd49601b tools/python/xen/lowlevel/xs/xs.c --- a/tools/python/xen/lowlevel/xs/xs.c Thu Apr 13 11:26:01 2006 +0100 +++ b/tools/python/xen/lowlevel/xs/xs.c Thu Apr 13 09:17:48 2006 -0700 @@ -589,7 +589,7 @@ static PyObject *xspy_transaction_end(Xs static PyObject *xspy_introduce_domain(XsHandle *self, PyObject *args) { - domid_t dom; + uint32_t dom; unsigned long page; unsigned int port; @@ -620,7 +620,7 @@ static PyObject *xspy_introduce_domain(X static PyObject *xspy_release_domain(XsHandle *self, PyObject *args) { - domid_t dom; + uint32_t dom; struct xs_handle *xh = xshandle(self); bool result = 0; @@ -677,7 +677,7 @@ static PyObject *xspy_get_domain_path(Xs static PyObject *xspy_get_domain_path(XsHandle *self, PyObject *args) { struct xs_handle *xh = xshandle(self); - int domid; + uint32_t domid; char *xsval; if (!xh)