From: Christoph Hellwig Subject: Re: Re: [linuxsh-dev] [PATCH] ALSA driver for Yamaa AICA on Sega Dreamcast Date: Tue, 18 Apr 2006 12:52:24 +0100 Message-ID: <20060418115224.GA8591@infradead.org> References: <1145232784.12804.2.camel@localhost.localdomain> <20060417012913.GA16821@linux-sh.org> <1145304037.9244.27.camel@localhost.localdomain> <1145310435.16138.83.camel@mindpipe> <20060417220512.GA16119@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: alsa-devel-admin@lists.sourceforge.net Errors-To: alsa-devel-admin@lists.sourceforge.net List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: To: Takashi Iwai Cc: Christoph Hellwig , Lee Revell , Adrian McMenamin , Paul Mundt , Alsa-devel , linux-sh , LKML List-Id: alsa-devel@alsa-project.org On Tue, Apr 18, 2006 at 12:17:46PM +0200, Takashi Iwai wrote: > Heh, the suggested line is what CondingStyle suggets -- the output of > indent program. Yeah, but better to fix "bad programming" :) indent only fixes indentation. Moving the if check to a different line as the function call changes more than indentation so indent doesn't do it. Yes, there's more to code codingstyle than just running indent :) ------------------------------------------------------- This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory! http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642