From: John Levon Subject: Re: [PATCH] change dom0 headers path Date: Thu, 20 Apr 2006 14:13:10 +0100 Message-ID: <20060420131310.GC840@totally.trollied.org> References: <20060420123936.GA840@totally.trollied.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On Thu, Apr 20, 2006 at 02:00:07PM +0100, Keir Fraser wrote: > >Fairly obviously, we need to clean up the hard-coded "linux" names used > >in includes. This is the first step in a number of changes around > >letting dom0 build on something other than Linux. > > > >What are the plans for these headers when the Linux kernel lives in > >some > >place other than the xen tree itself? We'd like to be able to share the > >structure definitions, but our ioctl values will differ from Linux's... > > I'd prefer an interfacing library (or libraries) that can target Linux > interfaces, Sun interfaces, etc. My understanding is that libxc *is* that library. > Maybe this only needs to be done for evtchn interfaces. I would have > hoped that libxenctrl and libxenguest would hide privcmd interfaces. I > wonder why so many things include ? Code is using ioctl() where it should be using a helper function. I don't mind looking into cleaning these things up at some point, but it doesn't seem critical right now. But we'd like to get a firm grasp on header naming so we can deal with the unfortunate two-way dependency these headers have between dom0 and dom0 userspace. IOW, I agree with you, but I think the patch needs to go in regardless. In particular, something like my patch will still be needed, even if it's just private to tools/libxc/. regards, john