From: John Levon Subject: Re: [PATCH] change dom0 headers path Date: Fri, 21 Apr 2006 18:55:45 +0100 Message-ID: <20060421175545.GA6224@totally.trollied.org> References: <20060420123936.GA840@totally.trollied.org> <20060420131310.GC840@totally.trollied.org> <2bebc381f42c49f9a65d5016fcf0ca71@cl.cam.ac.uk> <20060420134740.GA1887@totally.trollied.org> <2b451d3c2dd2ddd57f8b7bef3ca2a735@cl.cam.ac.uk> <20060420144037.GA2866@totally.trollied.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20060420144037.GA2866@totally.trollied.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On Thu, Apr 20, 2006 at 03:40:37PM +0100, John Levon wrote: > So, something more like: > > libxc/xc_linux.c > libxc/xc_solaris.c > libxc/xen/linux/ > libxc/xen/solaris/ Hmm. Looking at this, we've got an awful lot of duplicated code between xc_{linux,solaris}.c if we only let those files see the kernel headers containing privcmd_hypercall_t etc. Wouldn't it be better to have a libxc/xen/sys/[1] symlink so that xc_private.c and friends can continue to include privcmd_hypercall etc? That way the contents of xc_{linux,solaris}.c can contain only the parts that we'll genuinely differ by (use of /proc etc.). regards john [1] or some other name since 'dom0' won't do