From: "Zhai, Edwin" Subject: [PATCH] remove annoying pit debug info when booting smp guest Date: Sun, 23 Apr 2006 15:07:56 +0800 Message-ID: <20060423070756.GA16381@edwin-gen.ccr> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ian Pratt , Keir Fraser Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org remove annoying pit debug info when booting smp guest Signed-off-by: Edwin Zhai diff -r 1020c52c58c1 xen/arch/x86/hvm/i8254.c --- a/xen/arch/x86/hvm/i8254.c Sat Apr 22 10:41:53 2006 +0100 +++ b/xen/arch/x86/hvm/i8254.c Sun Apr 23 11:38:37 2006 +0800 @@ -154,8 +154,7 @@ static __inline__ s64 missed_ticks(PITCh hvm_time->pending_intr_nr += missed_ticks; } s->next_transition_time = current_time + (missed_ticks ) * s->period; - } else - printk("HVM_PIT:missed ticks < 0 \n"); + } return s->next_transition_time; } @@ -184,9 +183,8 @@ s64 pit_get_next_transition_time(PITChan return -1; break; case 2: - if (test_bit(_VCPUF_running, &(hvm_time->vcpu->vcpu_flags)) ) - next_time = missed_ticks(s, current_time); - else + next_time = missed_ticks(s, current_time); + if ( !test_bit(_VCPUF_running, &(hvm_time->vcpu->vcpu_flags)) ) return 0; break; case 3: @@ -566,13 +564,8 @@ void pickup_deactive_ticks(struct hvm_vi PITChannelState *s = &(vpit->channels[0]); if ( !active_timer(&(vpit->time_info.pit_timer)) ) { next_time = pit_get_next_transition_time(s, s->next_transition_time); - if (next_time > 0) + if (next_time >= 0) set_timer(&(s->hvm_time->pit_timer), s->next_transition_time); - else { - printk("HVM_PIT:not set_timer before resume next_time=%" - PRId64"!\n", next_time); - next_time = s->next_transition_time; - } } }