From: Christian Limpach Subject: Re: [RFC PATCH 22/35] subarch suport for idle loop (NO_IDLE_HZ for Xen) Date: Tue, 9 May 2006 16:13:57 +0100 Message-ID: <20060509151357.GH7834@cl.cam.ac.uk> References: <20060509084945.373541000@sous-sol.org> <20060509085156.694312000@sous-sol.org> <200605091521.19910.ak@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <200605091521.19910.ak@suse.de> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Andi Kleen Cc: Chris Wright , virtualization@lists.osdl.org, xen-devel@lists.xensource.com, linux-kernel@vger.kernel.org, Ian Pratt List-Id: xen-devel@lists.xenproject.org On Tue, May 09, 2006 at 03:21:19PM +0200, Andi Kleen wrote: > > > +extern void stop_hz_timer(void); > > +extern void start_hz_timer(void); > > + > > +void xen_idle(void); > > + > > static char * __init machine_specific_memory_setup(void) > > { > > unsigned long max_pfn = xen_start_info->nr_pages; > > @@ -65,4 +70,23 @@ static void __init machine_specific_arch > > console_use_vt = 0; > > conswitchp = NULL; > > } > > + > > + pm_idle = xen_idle; > > +} > > + > > +void xen_idle(void) > > I think that should be in some .c file, not a .h > > Probably applies to more of your functions too. I guess I agree, although I was mostly following the examples in other mach setup_arch_*.h files. christian