From: Christoph Hellwig Subject: Re: [RFC PATCH 03/35] Add Xen interface header files Date: Tue, 9 May 2006 16:15:16 +0100 Message-ID: <20060509151516.GA16332@infradead.org> References: <20060509084945.373541000@sous-sol.org> <20060509085147.903310000@sous-sol.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20060509085147.903310000@sous-sol.org> Sender: linux-kernel-owner@vger.kernel.org To: Chris Wright Cc: linux-kernel@vger.kernel.org, virtualization@lists.osdl.org, xen-devel@lists.xensource.com, Ian Pratt , Christian Limpach List-Id: xen-devel@lists.xenproject.org > Signed-off-by: Christian Limpach > Signed-off-by: Chris Wright > --- > include/xen/interface/arch-x86_32.h | 197 +++++++++++++++ that kind of stuff needs to go to asm/ > include/xen/interface/event_channel.h | 205 +++++++++++++++ instead of interface please use something shorter, we'll see this all over the includes statements. intf for example. > +#ifdef __XEN__ > +#define __DEFINE_GUEST_HANDLE(name, type) \ > + typedef struct { type *p; } __guest_handle_ ## name > +#else > +#define __DEFINE_GUEST_HANDLE(name, type) \ > + typedef type * __guest_handle_ ## name > +#endif please get rid of all these stupid typedefs > +#ifndef __ASSEMBLY__ > +/* Guest handles for primitive C types. */ > +__DEFINE_GUEST_HANDLE(uchar, unsigned char); > +__DEFINE_GUEST_HANDLE(uint, unsigned int); > +__DEFINE_GUEST_HANDLE(ulong, unsigned long); don't use uchar/uint/ulong types ever. And in things like hypervisor/kernel interfaces always use __u* types.