From: Christian Limpach Subject: Re: [RFC PATCH 18/35] Support gdt/idt/ldt handling on Xen. Date: Tue, 9 May 2006 19:14:44 +0100 Message-ID: <20060509181444.GP7834@cl.cam.ac.uk> References: <20060509084945.373541000@sous-sol.org> <20060509085155.177937000@sous-sol.org> <4460AC12.3000006@mbligh.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <4460AC12.3000006@mbligh.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "Martin J. Bligh" Cc: Chris Wright , virtualization@lists.osdl.org, xen-devel@lists.xensource.com, linux-kernel@vger.kernel.org, Ian Pratt List-Id: xen-devel@lists.xenproject.org On Tue, May 09, 2006 at 07:49:54AM -0700, Martin J. Bligh wrote: > >+static inline void load_TLS(struct thread_struct *t, unsigned int cpu) > >+{ > >+#define C(i) > >HYPERVISOR_update_descriptor(virt_to_machine(&get_cpu_gdt_table(cpu)[GDT_ENTRY_TLS_MIN + i]), *(u64 *)&t->tls_array[i]) > >+ C(0); C(1); C(2); > >+#undef C > >+} > > Please just expand this or make it a real function call (static inline), > not a temporary macro .. Yes, I've added an inline function to do a single descriptor. Should I change the non-xen case as well? It was the inspiration for this code ;-) christian