From: Andi Kleen Subject: Re: [RFC PATCH 15/35] subarch support for controlling interrupt delivery Date: Tue, 9 May 2006 18:31:37 +0200 Message-ID: <200605091831.37757.ak@suse.de> References: <20060509084945.373541000@sous-sol.org> <200605091807.57522.ak@suse.de> <20060509162959.GL7834@cl.cam.ac.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20060509162959.GL7834@cl.cam.ac.uk> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Christian Limpach Cc: xen-devel@lists.xensource.com, Ian Pratt , linux-kernel@vger.kernel.org, "Martin J. Bligh" , Chris Wright , virtualization@lists.osdl.org List-Id: xen-devel@lists.xenproject.org On Tuesday 09 May 2006 18:29, Christian Limpach wrote: > On Tue, May 09, 2006 at 06:07:57PM +0200, Andi Kleen wrote: > > > > > > > > Anybody want to comment on the performance impact of making > > > local_irq_* non-inline functions? > > > > I would guess for that much inline code it will be even a win to not > > inline because it will save icache. > > Maybe, although some of the macros compile down to only 2-3 instructions. Can you post before/after vmlinux size numbers for inline/out of line? -Andi