From: Andi Kleen Subject: Re: [RFC PATCH 17/35] Segment register changes for Xen Date: Thu, 11 May 2006 12:41:25 +0200 Message-ID: <200605111241.26252.ak@suse.de> References: <20060509084945.373541000@sous-sol.org> <20060510203015.GA13949@elf.ucw.cz> <4463133A.8060806@argo.co.il> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4463133A.8060806@argo.co.il> Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org To: Avi Kivity Cc: Pavel Machek , virtualization@lists.osdl.org, Chris Wright , xen-devel@lists.xensource.com, linux-kernel@vger.kernel.org, Ian Pratt List-Id: xen-devel@lists.xenproject.org On Thursday 11 May 2006 12:34, Avi Kivity wrote: > Pavel Machek wrote: > > Really? If someone does > > > > if (something) > > clearsegment(seg) > > somethingelse(); > > > > ... he'll get very confusing behaviour instead of compile error. > > > > Okay, that's weaker argument than expected... > > > > Also clearsegment(x) clearsegment(y); will compile when it should not. > > > > Also clearsegment(i++) will behave strangely. So perhaps > > > > #define clearsegment(seg) do { seg; } while (0) > > > > static inline void clearsegment(int seg) {} It's all mood because the complete function is wrongly named and probably should just go. -Andi