From: Chris Wright Subject: Re: [PATCH] linux: eliminate E820 tables Date: Thu, 11 May 2006 17:05:12 -0700 Message-ID: <20060512000512.GA2724@moss.sous-sol.org> References: <44635590.76E4.0078.0@novell.com> <4463810E.6010604@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <4463810E.6010604@us.ibm.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Anthony Liguori Cc: Xen-devel@lists.xensource.com, Jan Beulich List-Id: xen-devel@lists.xenproject.org * Anthony Liguori (aliguori@us.ibm.com) wrote: > Why do we need CONFIG_XEN guards in xen specific files? > > Should setup-xen.c and e820-xen.c be built when CONFIG_XEN isn't set? Yes, but *-xen.c is temporary. Adding CONFIG_XEN annotations make the diffs smaller and it's easier to keep in sync with the corresponding file's changes. thanks, -chris