From: Pavel Machek Subject: Re: [RFC PATCH 24/35] Add support for Xen event channels. Date: Fri, 12 May 2006 21:41:27 +0000 Message-ID: <20060512214127.GA4189@ucw.cz> References: <20060509084945.373541000@sous-sol.org> <20060509085157.491027000@sous-sol.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20060509085157.491027000@sous-sol.org> Sender: linux-kernel-owner@vger.kernel.org To: Chris Wright Cc: linux-kernel@vger.kernel.org, virtualization@lists.osdl.org, xen-devel@lists.xensource.com, Ian Pratt , Christian Limpach List-Id: xen-devel@lists.xenproject.org Hi! > +++ linus-2.6/drivers/xen/core/evtchn.c > @@ -0,0 +1,887 @@ msssng wwls? > +/* NB. Interrupts are disabled on entry. */ > +asmlinkage void evtchn_do_upcall(struct pt_regs *regs) > +{ > + unsigned long l1, l2; > + unsigned int l1i, l2i, port; Better variable names would be nice. Pavel -- Thanks for all the (sleeping) penguins.