From: Andrew Morton Subject: Re: [RFC PATCH 29/35] Add the Xen virtual console driver. Date: Sat, 13 May 2006 07:29:38 -0700 Message-ID: <20060513072938.642bf600.akpm@osdl.org> References: <20060509084945.373541000@sous-sol.org> <20060509085159.285105000@sous-sol.org> <20060513052757.59446e03.akpm@osdl.org> <4465D63F.4000605@yahoo.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4465D63F.4000605@yahoo.com.au> Sender: linux-kernel-owner@vger.kernel.org To: Nick Piggin Cc: chrisw@sous-sol.org, linux-kernel@vger.kernel.org, virtualization@lists.osdl.org, xen-devel@lists.xensource.com, ian.pratt@xensource.com, Christian.Limpach@cl.cam.ac.uk List-Id: xen-devel@lists.xenproject.org Nick Piggin wrote: > > Andrew Morton wrote: > > >>+static void kcons_write_dom0( > >>+ struct console *c, const char *s, unsigned int count) > >>+{ > >>+ int rc; > >>+ > >>+ while ((count > 0) && > >>+ ((rc = HYPERVISOR_console_io( > >>+ CONSOLEIO_write, count, (char *)s)) > 0)) { > >>+ count -= rc; > >>+ s += rc; > >>+ } > >>+} > > > > > > must.. not.. mention.. coding.. style.. > > Someone should write you a script to go through a patch and flag the > most common style mistakes. Have the output formatted to look like > you're replying to the mail, and wire it up to your inbox ;) > Even better, someone should write a coding style document, so people get it right from the outset. Clever, aren't I?