From: Andrew Morton Subject: Re: [PATCH 0/13: eCryptfs] eCryptfs Patch Set Date: Sat, 13 May 2006 20:13:41 -0700 Message-ID: <20060513201341.63590cff.akpm@osdl.org> References: <20060513033742.GA18598@hellewell.homeip.net> <44655ECD.10404@yahoo.com.au> <44669D12.5050306@yahoo.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: michael.craig.thompson@gmail.com, phillip@hellewell.homeip.net, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, viro@ftp.linux.org.uk, mike@halcrow.us, mhalcrow@us.ibm.com, mcthomps@us.ibm.com, toml@us.ibm.com, yoder1@us.ibm.com, jmorris@namei.org, sct@redhat.com, ezk@cs.sunysb.edu, dhowells@redhat.com Return-path: Received: from smtp.osdl.org ([65.172.181.4]:3971 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S932351AbWENDRM (ORCPT ); Sat, 13 May 2006 23:17:12 -0400 To: Nick Piggin In-Reply-To: <44669D12.5050306@yahoo.com.au> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Nick Piggin wrote: > > Michael Thompson wrote: > > On 5/12/06, Nick Piggin wrote: > > >> BTW. I'm not sure if linux-fsdevel has different conventions; however > >> usually you don't break up a patch according to files, but logical > >> components or transformations from one "sane" kernel tree to the next. > >> And that means things keep compiling and working. > > > > > > The files themselves are broken down into logical components, so the > > per-file patch approach seems reasonable to me. > > Half a filesystem is a logical component? > > At the very least it wires up all the kconfig stuff _first_, so it > breaks the tree from about patch 3 until 13. Doesn't matter. The rule is stated as "kernel should compile at each step", but the _real_ rule is "don't break git-bisect". Nobody is going to include a half-applied filesystem in their .config while performing git-bisection, so it can go in in any order.