From: Greg KH Subject: Re: [PATCH 0/13: eCryptfs] eCryptfs Patch Set Date: Sat, 13 May 2006 20:54:22 -0700 Message-ID: <20060514035422.GA6451@kroah.com> References: <20060513033742.GA18598@hellewell.homeip.net> <44655ECD.10404@yahoo.com.au> <44669D12.5050306@yahoo.com.au> <20060513201341.63590cff.akpm@osdl.org> <4466A37F.4030601@yahoo.com.au> <20060514034346.GA4427@halcrow.us> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Nick Piggin , Andrew Morton , michael.craig.thompson@gmail.com, phillip@hellewell.homeip.net, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, viro@ftp.linux.org.uk, mhalcrow@us.ibm.com, mcthomps@us.ibm.com, toml@us.ibm.com, yoder1@us.ibm.com, jmorris@namei.org, sct@redhat.com, ezk@cs.sunysb.edu, dhowells@redhat.com Return-path: Received: from ns2.suse.de ([195.135.220.15]:11497 "EHLO mx2.suse.de") by vger.kernel.org with ESMTP id S964785AbWEND4h (ORCPT ); Sat, 13 May 2006 23:56:37 -0400 To: Michael Halcrow Content-Disposition: inline In-Reply-To: <20060514034346.GA4427@halcrow.us> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Sat, May 13, 2006 at 10:43:46PM -0500, Michael Halcrow wrote: > On Sun, May 14, 2006 at 01:26:55PM +1000, Nick Piggin wrote: > > Compiling at each step is better than not. But my main point is > > that it is superfluously broken into multiple patches. > > This comment is from about a year ago, so it probably has fallen off > the radar: > > At 2005-06-02 14:51:54, Greg K-H wrote: > > On Thu, Jun 02, 2005 at 07:32:19AM -0500, Michael Halcrow wrote: > > > What sort of > > > logical chunks would you consider to be appropriate? Separate patches > > > for each file (inode.c, file.c, super.c, etc.), which represent sets > > > of functions for each major VFS object? > > > > Yes. Yes, but don't break the build along the way. thanks, greg k-h