From: Ewan Mellor Subject: Re: [PATCH] [XM-TEST] block device write verify test 2nd attempt Date: Wed, 24 May 2006 23:01:04 +0100 Message-ID: <20060524220104.GA7657@leeni.uk.xensource.com> References: <1148380556.10003.4.camel@localhost.localdomain> <20060523114019.GB16064@leeni.uk.xensource.com> <1148387736.10003.26.camel@localhost.localdomain> <20060524102041.GA3414@leeni.uk.xensource.com> <1148468908.7791.31.camel@localhost.localdomain> <20060524123757.GB3414@leeni.uk.xensource.com> <1148476190.7791.47.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1148476190.7791.47.camel@localhost.localdomain> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Harry Butterworth Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On Wed, May 24, 2006 at 02:09:49PM +0100, Harry Butterworth wrote: > > Modifying the ramdisk is not verboten, > > but it is a right pain in the backside for everyone, particularly me because I > > need to build a new one and upload it and all of its source (because of the > > GPL) to xm-test.xensource.com. > > The current test is modifying the ramdisk to add `tee` (as well as fancy > head which we don't need anymore). > > Are you going to accept the patch if it requires the addition of `tee` > to the ramdisk? Or should I change the test to read the data back in > domU---which I was specifically trying to avoid. > > The problem with reading the data back in domU after having written it > is that it might mask bugs in the block driver. Reading the data back > might cause it to be committed to the device where otherwise a bug might > cause it to be lost. I think that's a fair point, so yes, we'll have to rev the ramdisk anyway. Ewan.