From: John Levon Subject: Re: [patch] [3/3] dom0_ops explicitly sized types Date: Sat, 27 May 2006 01:42:52 +0100 Message-ID: <20060527004252.GA8702@totally.trollied.org> References: <20060525153957.GO6710@rhun.ibm.com> <1148583731.15517.16.camel@basalt.austin.ibm.com> <20060526133221.GA5569@rhun.e-centre.net> <1148653733.24768.49.camel@localhost.localdomain> <1148657437.26643.5.camel@basalt.austin.ibm.com> <1148660853.24768.97.camel@localhost.localdomain> <1148665048.26643.12.camel@basalt.austin.ibm.com> <20060526185746.GG2724@moss.sous-sol.org> <20060526193805.GA5171@totally.trollied.org> <20060526195730.GH2724@moss.sous-sol.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20060526195730.GH2724@moss.sous-sol.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Chris Wright Cc: Muli Ben-Yehuda , xen-devel , xen-ppc-devel@lists.xensource.com, Hollis Blanchard , Ian Campbell List-Id: xen-devel@lists.xenproject.org On Fri, May 26, 2006 at 12:57:30PM -0700, Chris Wright wrote: > > This won't work on platforms that don't provide __u64. Xen needs to > > define them somewhere for the userspace. > > +++ b/linux-2.6-xen-sparse/include/xen/public/privcmd.h > > That's specifically the part I'm talking about. > > WRT Xen's public headers, that's a different issue, however there's > still some of the same namespace concerns. Of course, I'd be thrilled > to make it all __u64 in public headers w/ appropriate types.h involved. > And realisitically, platforms will all need some santized version of the > headers anyway. Yes, but hopefully it will be possible to provide the structure definitions in some generic form, possibly by including another header that has the platform-specific parts (such as ioctl numbers, __u64 definitions on Solaris, etc.) It would be a shame if we had to duplicate the structure definitions 3 or more times. regards john