From: Dominik Brodowski Subject: Re: [PATCH] return error when failing to set minfreq Date: Tue, 6 Jun 2006 10:32:25 +0200 Message-ID: <20060606083225.GA9351@dominikbrodowski.de> References: <20060525223403.GA3908@inferi.kami.home> <20060605183147.GD8603@inferi.kami.home> Mime-Version: 1.0 Return-path: Content-Disposition: inline In-Reply-To: <20060605183147.GD8603@inferi.kami.home> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: cpufreq-bounces@lists.linux.org.uk Errors-To: cpufreq-bounces+glkc-cpufreq=m.gmane.org+glkc-cpufreq=m.gmane.org@lists.linux.org.uk Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: cpufreq@lists.linux.org.uk On Mon, Jun 05, 2006 at 08:31:48PM +0200, Mattia Dongili wrote: > Hello, > > no comment on the following? > > On Fri, May 26, 2006 at 12:34:04AM +0200, Mattia Dongili wrote: > > Hello, > > I just stumbled on this bug/feature, this is how to reproduce it: > > > > # echo 450000 > /sys/devices/system/cpu/cpu0/cpufreq/scaling_min_freq > > # echo 450000 > /sys/devices/system/cpu/cpu0/cpufreq/scaling_max_freq > > # echo powersave > /sys/devices/system/cpu/cpu0/cpufreq/scaling_governor > > # cpufreq-info -p > > 450000 450000 powersave > > # echo 1800000 > /sys/devices/system/cpu/cpu0/cpufreq/scaling_min_freq ; echo $? > > 0 > > # cpufreq-info -p > > 450000 450000 powersave > > > > Here it is. The kernel refuses to set a min_freq higher than the > > max_freq but it allows a max_freq lower than min_freq (lowering min_freq > > also). > > > > I'm unsure if things could be improved here. The offending instruction > > is in cpufreq_verify_within_limits (cpufreq.h:241): > > > > if (policy->min > policy->max) > > policy->min = policy->max; > > > > This behaviour is pretty straightforward (but undocumented) and it > > doesn't return an error altough failing to accomplish the requested > > action (set min_freq). > > The problem (IMO) is basically that userspace is not allowed to set a > > full policy atomically while the kernel always does that thus it must > > enforce an ordering on operations. > > > > The attached patch returns -EINVAL if trying to increase frequencies > > starting from scaling_min_freq and documents the correct ordering of > > writes. > > > > Signed-off-by: Mattia Dongili Signed-off-by: Dominik Brodowski Thanks, Dominik