From: Ewan Mellor Subject: Re: [PATCH][ACM][UPDATE] python tools and support for resource labeling Date: Thu, 29 Jun 2006 14:07:02 +0100 Message-ID: <20060629130702.GA8676@leeni.uk.xensource.com> References: <44A2F47A.7040205@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <44A2F47A.7040205@us.ibm.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "Bryan D. Payne" Cc: xen-devel@lists.xensource.com, sailer@us.ibm.com List-Id: xen-devel@lists.xenproject.org On Wed, Jun 28, 2006 at 05:28:26PM -0400, Bryan D. Payne wrote: > Same as previous patch, except that we no longer use xml marshaling. > > Signed-off-by: Bryan D. Payne > Signed-off-by: Reiner Sailer This patch continues to be a problem: > @@ -999,6 +1008,19 @@ def xm_block_attach(args): > if len(args) == 5: > vbd.append(['backend', args[4]]) > > + # verify that policy permits attaching this resource > + try: > + dominfo = server.xend.domain(dom) > + domid = sxp.child_value(dominfo, 'domid') > + (tmp1, label, tmp2, tmp3) = security.get_ssid(domid) > + security.res_security_check(args[1], label) > + except security.ACMError, e: > + print e.value > + sys.exit(1) > + except: > + traceback.print_exc(limit=1) > + sys.exit(1) > + > server.xend.domain.device_create(dom, vbd) If there is no security policy in force, then get_ssid throws an ACMError. This means that all xm-test's block-attach tests are currently failing. Ewan.