From: Chris Wright <chrisw@sous-sol.org>
Subject: Re: [RFC PATCH 01/33] Add apply_to_page_range() function
Date: Tue, 18 Jul 2006 12:29:25 -0700
Message-ID: <20060718192925.GC2654@sequoia.sous-sol.org>
References: <20060718091807.467468000@sous-sol.org>
	<20060718091945.432845000@sous-sol.org>
	<20060718103850.GD3748@stusta.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <xen-devel-bounces@lists.xensource.com>
Content-Disposition: inline
In-Reply-To: <20060718103850.GD3748@stusta.de>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Adrian Bunk <bunk@stusta.de>
Cc: Andrew Morton <akpm@osdl.org>, Zachary Amsden <zach@vmware.com>, Jeremy Fitzhardinge <jeremy@goop.org>, xen-devel@lists.xensource.com, Ian Pratt <ian.pratt@xensource.com>, Rusty Russell <rusty@rustcorp.com.au>, linux-kernel@vger.kernel.org, Andi Kleen <ak@suse.de>, Chris Wright <chrisw@sous-sol.org>, virtualization@lists.osdl.org, Christian Limpach <Christian.Limpach@cl.cam.ac.uk>
List-Id: xen-devel@lists.xenproject.org

* Adrian Bunk (bunk@stusta.de) wrote:
> On Tue, Jul 18, 2006 at 12:00:01AM -0700, Chris Wright wrote:
> >...
> > --- a/mm/memory.c	Fri Mar 24 04:29:46 2006 +0000
> > +++ b/mm/memory.c	Fri Mar 24 04:30:48 2006 +0000
> > @@ -1358,6 +1358,100 @@ int remap_pfn_range(struct vm_area_struc
> >  }
> >  EXPORT_SYMBOL(remap_pfn_range);
> >  
> > +static inline int apply_to_pte_range(struct mm_struct *mm, pmd_t *pmd,
> > +				     unsigned long addr, unsigned long end,
> > +				     pte_fn_t fn, void *data)
> >...
> > +static inline int apply_to_pmd_range(struct mm_struct *mm, pud_t *pud,
> > +				     unsigned long addr, unsigned long end,
> > +				     pte_fn_t fn, void *data)
> >...
> > +static inline int apply_to_pud_range(struct mm_struct *mm, pgd_t *pgd,
> > +				     unsigned long addr, unsigned long end,
> > +				     pte_fn_t fn, void *data)
> >...
> 
> Please avoid "inline" in C files.
> 
> (gcc already automatically inlines static functions with only one caller.)

Sure, that's fair.  The surrounding similar code follows the same format 
as above, perhaps you plan to patch?