From: Karl MacMillan <kmacmillan@mentalrootkit.com>
To: "Christopher J. PeBenito" <cpebenito@tresys.com>
Subject: Re: [PATCH 3/6] netfilter integration: module store support
Date: Wed, 26 Jul 2006 16:55:47 -0400
Cc: SELinux Mail List <selinux@tycho.nsa.gov>
References: <1153168354.10090.48.camel@sgc> <1153235311.10744.24.camel@localhost.localdomain> <1153842596.8634.18.camel@sgc.columbia.tresys.com>
In-Reply-To: <1153842596.8634.18.camel@sgc.columbia.tresys.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="utf-8"
Message-Id: <200607261655.47982.kmacmillan@mentalrootkit.com>
Sender: owner-selinux@tycho.nsa.gov

On Tuesday 25 July 2006 11:49, Christopher J. PeBenito wrote:
> On Tue, 2006-07-18 at 11:08 -0400, Karl MacMillan wrote:
> > On Mon, 2006-07-17 at 16:32 -0400, Christopher J. PeBenito wrote:
> > > Adds support for committing the netfilter_contexts file, and copying it
> > > out to the running system.
> > >
> > >  libsemanage/src/direct_api.c     |   25 ++++++++++++++++++-------
> > >  libsemanage/src/semanage_store.c |   11 +++++++++++
> > >  libsemanage/src/semanage_store.h |    1 +
> > >  3 files changed, 30 insertions(+), 7 deletions(-)
> >
> > Both of those if blocks are very difficult to parse and adding even more
> > expressions to them just makes it worse. I don't know what Steve thinks,
> > but blindly continuing poor coding practices will just make the code
> > base worse over time (which I think has happened). I would prefer to see
> > cleanups happen when the code is being changed.
>
> Blame lindent.

It is not the indentation that is the problem it is the grouping of too many 
function calls into a single if statement. I'll be happy to blame lindent if 
you want (or anyone or anything else), but I still think it needs fixing.

Karl

--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.