From: Karl MacMillan <kmacmillan@mentalrootkit.com>
To: "Christopher J. PeBenito" <cpebenito@tresys.com>
Subject: Re: [PATCH 4/6] netfilter integration: add netfilter =?utf-8?q?contexts=09sorting?=
Date: Wed, 26 Jul 2006 16:57:46 -0400
Cc: Joshua Brindle <jbrindle@tresys.com>,
        SELinux Mail List <selinux@tycho.nsa.gov>
References: <1153168355.10090.49.camel@sgc> <1153244161.10744.78.camel@localhost.localdomain> <1153842829.8634.23.camel@sgc.columbia.tresys.com>
In-Reply-To: <1153842829.8634.23.camel@sgc.columbia.tresys.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="utf-8"
Message-Id: <200607261657.46881.kmacmillan@mentalrootkit.com>
Sender: owner-selinux@tycho.nsa.gov

On Tuesday 25 July 2006 11:53, Christopher J. PeBenito wrote:
> On Tue, 2006-07-18 at 13:36 -0400, Karl MacMillan wrote:
> > On Tue, 2006-07-18 at 13:13 -0400, Joshua Brindle wrote:
> > > Karl MacMillan wrote:
> > > > On Mon, 2006-07-17 at 16:32 -0400, Christopher J. PeBenito wrote:
> > > >> Add sorting function for netfilter contexts.
> > > >>
> > > >>  libsemanage/src/direct_api.c     |    9 +
> > > >>  libsemanage/src/semanage_store.c |  189
> > > >> +++++++++++++++++++++++++++++++++++++--
> > > >> libsemanage/src/semanage_store.h |    6 +
> > > >>  3 files changed, 198 insertions(+), 6 deletions(-)
> > > >
> > > > Is this correct location for the netfilter sorting (file and
> > > > library)? The file context sorting is a mess now and, again, just
> > > > continuing that seems like a bad idea.
> > >
> > > libsemanage owns and manages these files, it is indeed the correct
> > > place to do sorting.
> >
> > There are times you want to sort these files other than via semanage -
> > for example it would be nice to create a tool to let the developer test
> > sorting. Putting the sorting infrastructure in libsepol or libselinux
> > would seem more appropriate to allow that.
> >
> > Seems to me that libsemanage is too large as it is - keeping it focused
> > away from the details of policy representation (whether it be .te, .if,
> > or secmark) would help.
> >
> > Even if it stays in libsemanage, semanage_store.c seems to be the wrong
> > location.
>
> These additions are right after the file context sorting functions.  It
> wouldn't make sense for file and netfilter sorting to be in different
> places.  Moving functions would be outside the scope of this patchset.

That the current code is not ideal is not, in my opinion, a justification. 
This is not a good location for this code.

Karl

--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.