From: Andi Kleen Subject: Re: [patch 2/8] Implement always-locked bit ops, for memory shared with an SMP hypervisor. Date: Thu, 3 Aug 2006 06:47:14 +0200 Message-ID: <200608030647.14159.ak@suse.de> References: <20060803002510.634721860@xensource.com> <200608030555.34569.ak@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Christoph Lameter Cc: Zachary Amsden , akpm@osdl.org, xen-devel@lists.xensource.com, Ian Pratt , linux-kernel@vger.kernel.org, Chris Wright , virtualization@lists.osdl.org List-Id: xen-devel@lists.xenproject.org On Thursday 03 August 2006 06:25, Christoph Lameter wrote: > On Thu, 3 Aug 2006, Andi Kleen wrote: > > > On Thursday 03 August 2006 03:25, Christoph Lameter wrote: > > > > > Good idea. This will also make it easier to support this special > > > functionality. And it will avoid use in contexts where these are > > > not necessary. > > > > I think it's a bad idea. We don't want lots of architecture ifdefs > > in some Xen specific file > > Thats not how it would be done. We would do this with > architecture specific xen files and a default in asm-generic. It's cleaner to just do it in the generic code. I think for most architectures it is only a one liner anyways if done properly. -Andi