From: Ryan Harper Subject: Re: [PATCH 3/3] tools/xm-test: add cpus parm test in create bucket Date: Mon, 14 Aug 2006 12:37:53 -0500 Message-ID: <20060814173753.GN1694@us.ibm.com> References: <20060814165756.GM1694@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser Cc: Ryan Harper , xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org * Keir Fraser [2006-08-14 12:35]: > > > > On 14/8/06 5:57 pm, "Ryan Harper" wrote: > > > This patch adds a test in the create bucket to exercise the parsing of > > the cpus parameter. This patch utilizes the new form of getVcpuInfo > > from [PATCH 1/3]. > > Do these tests succeed even if, e.g. The test machine has only one CPU? Xen > will clip the cpumasks when it receives them (also it will fail the > set_affinity call if none of the specified CPUs are online) but this may not > matter if the affinity data is cached within xend and getVcpuInfo obtains > info from that cache. Good question. I'll check and resend this test with the smp level check so this test will be skipped if the host is not smp capable. -- Ryan Harper Software Engineer; Linux Technology Center IBM Corp., Austin, Tx (512) 838-9253 T/L: 678-9253 ryanh@us.ibm.com