From: Ryan Harper Subject: Re: [PATCH 3/3] tools/xm-test: add cpus parm test in create bucket Date: Wed, 16 Aug 2006 10:07:53 -0500 Message-ID: <20060816150753.GY1694@us.ibm.com> References: <20060816144957.GX1694@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser Cc: Ryan Harper , xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org * Keir Fraser [2006-08-16 10:00]: > On 16/8/06 3:49 pm, "Ryan Harper" wrote: > > >>> As long as the first cpu in the mask is available then the affinity > >>> settings will succeed. > >> > >> Really? Xen itself doesn't have such a test (at least not any more) I > >> believe. Xen ANDs the mask with cpu_online_map and then complains if the > >> result is empty. > > > > Ah, ok. Then they've been working because of the size of the machine > > I'm on. I'll change the test values such that I have a set for 2, 4, > > and 8 ensuring that each set doesn't use values that won't be > > available. I can then run largest set that can run on the host. > > Are you *sure* the tests don't just work as they are? I raised the issue as > a possible problem -- not because I'm certain it's a problem. As I said, > xend may hide from the user the details of what Xen does to the affinity > mask. So, have you tried running your new tests on a machine booted with the > nosmp parameter to Xen (not dom0 -- you want to boot with one physical cpu)? I tried with maxcpu=1, and that failed to produce the required output as with only one cpu which prompted me to add the smp check to ensure I had enough vcpus. I've not tried the nosmp, but I imagine that the results will be the same. Let me give the current test a run on a 2-way, and I'll give nosmp a try as well. If they fail I'll change the test values accordingly. -- Ryan Harper Software Engineer; Linux Technology Center IBM Corp., Austin, Tx (512) 838-9253 T/L: 678-9253 ryanh@us.ibm.com