From: Arnd Bergmann Subject: Re: [PATCH 04/18] [PATCH] BLOCK: Separate the bounce buffering code from the highmem code [try #4] Date: Tue, 29 Aug 2006 15:59:20 +0200 Message-ID: <200608291559.20802.arnd.bergmann@de.ibm.com> References: <200608281352.58281.arnd.bergmann@de.ibm.com> <22040.1156537104@warthog.cambridge.redhat.com> <29516.1156859236@warthog.cambridge.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Sam Ravnborg , axboe@kernel.dk, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Return-path: Received: from e6.ny.us.ibm.com ([32.97.182.146]:31120 "EHLO e6.ny.us.ibm.com") by vger.kernel.org with ESMTP id S964974AbWH2N7X convert rfc822-to-8bit (ORCPT ); Tue, 29 Aug 2006 09:59:23 -0400 To: David Howells In-Reply-To: <29516.1156859236@warthog.cambridge.redhat.com> Content-Disposition: inline Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Tuesday 29 August 2006 15:47, David Howells wrote: > Arnd Bergmann wrote: >=20 > > You could write it as > >=20 > > bounce-$(CONFIG_MMU) +=3D bounce.o > > obj-$(CONFIG_BLOCK) =A0+=3D $(bounce-y) >=20 > I could, yes, but why? =A0What does it buy? =A0I think this: >=20 > =A0=A0=A0=A0=A0=A0=A0=A0ifeq ($(CONFIG_MMU)$(CONFIG_BLOCK),yy) > =A0=A0=A0=A0=A0=A0=A0=A0obj-y +=3D bounce.o > =A0=A0=A0=A0=A0=A0=A0=A0endif >=20 > is clearer. I remember having seen the first one in the kernel before (e.g. in arch/powerpc/kernel/Makefile), but not the other one. I agree that it doesn't make much difference at all, but it would be nice to be consistant. Arnd <>< - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html