From: Horms Subject: Re: Re: [PATCH] kexec: framework and i386 (Take XIV) Date: Fri, 1 Sep 2006 19:21:17 +0900 Message-ID: <20060901102116.GN17801@verge.net.au> References: <20060831074259.GB23148@verge.net.au> <88C6CCDB437DC3takebe_akio@jp.fujitsu.com> <20060901025610.GE31034@verge.net.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Akio Takebe Cc: Ian Pratt , Kazuo Moriwaka , xen-devel@lists.xensource.com, "Zou, Nanhai" , Isaku Yamahata , Magnus Damm , Mark Williamson , xen-ia64-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On Fri, Sep 01, 2006 at 05:45:59PM +0900, Akio Takebe wrote: > >Hi, Horms > > > >>That seems like a good idea to me. Though I think you are missing { }. > >>Can you test to see if this works? > >Oops, You're right. But I think unknown_nmi_error() is not called, > >because crash_kexec() is called before that. > Sorry. > In the only case of CONFIG_KEXEC=y, the above is right. Yes, I think that is the case. I will put your patch into the kexec series, as I think that it is a worthy addition. -- Horms H: http://www.vergenet.net/~horms/ W: http://www.valinux.co.jp/en/