From: Steven Smith Subject: Re: [PATCH] Paravirt framebuffer use xvc as console [4/5] Date: Wed, 6 Sep 2006 10:17:38 +0100 Message-ID: <20060906091738.GF3257@cam.ac.uk> References: <1157227130.11059.44.camel@aglarond.local> <20060904090111.GB4812@cam.ac.uk> <1157472719.7571.90.camel@aglarond.local> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1477472672==" Return-path: In-Reply-To: <1157472719.7571.90.camel@aglarond.local> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Mime-version: 1.0 Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jeremy Katz Cc: xen-devel , Markus Armbruster , sos22@srcf.ucam.org, Amos Waterland List-Id: xen-devel@lists.xenproject.org --===============1477472672== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="TU+u6i6jrDPzmlWF" Content-Disposition: inline --TU+u6i6jrDPzmlWF Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > > > This is the patch from Amos Waterland for the xenconsole to > > > use /dev/xvc0 instead of taking over ttys. I've fixed a few places > > > which needed to check for XVC mode in addition to serial mode. Also, > > > until LANANA responds with an official minor, I've adjusted it to use > > > char 250/187 (in the experimental range) as opposed to 204/187. > > >=20 > > > (Should be identical to this patch from last time) > > Does this have anything to do with the virtual framebuffer work, or > > does it stand alone? > It stands alone, but without it, the framebuffer bits get a little > confusing to actually try to have used as the console. What goes wrong? > > > @@ -194,11 +209,17 @@ static int __init xen_console_init(void) > > > kcons_info.write =3D kcons_write_dom0; > > > } else { > > > if (xc_mode =3D=3D XC_DEFAULT) > > > - xc_mode =3D XC_TTY; > > > + xc_mode =3D XC_XVC; > > Not convinced we want to change the default until a little while after > > the rest of the patch gets merged. > The default *HAS* to be changed -- otherwise, the xvc console tries to > take over ttys (which is really really really wrong in the guest) So why have we survived this far without it? If XC_TTY is completely broken, why not remove it completely? Steven. --TU+u6i6jrDPzmlWF Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (GNU/Linux) iD8DBQFE/pIyO4S8/gLNrjcRAuRFAKCwpyOts65tI9l5DbHWnj8Iz0dNJwCfaJgc AcKmOucA9I6FBgXOmb1aHhg= =o7v0 -----END PGP SIGNATURE----- --TU+u6i6jrDPzmlWF-- --===============1477472672== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --===============1477472672==--